daohualiuxiang/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	98db7babcc	test: fix pummel/test-net-connect-memleak * Run the garbage collector before creating the big array. It doesn't matter now but if in the future something in node.js core creates a lot of reclaimable garbage, that will break the test's expectation. * The first RSS check was being done too late. The garbage collector might have run before the check, throwing off the 'reclaimed memory' calculation. * Due to changes in how V8 represents the big array internally, the actual memory usage is just below 256 MB on x64. Update the test's expectation.	2013-08-01 16:07:46 +02:00
Ben Noordhuis	acd0df4ad9	test: fix pummel test out-of-memory errors Fix the following OOM error in pummel/test-net-connect-memleak and pummel/test-tls-connect-memleak: FATAL ERROR: CALL_AND_RETRY_0 Allocation failed - process out of memory Commit v8/v8@91afd39 increases the size of the deoptimization table to the extent that a 64M float array pushes it over the brink. Switch to SMIs so it stays below the limit. pummel/test-net-connect-memleak is still failing albeit with a different error this time. Needs further investigation. === release test-net-connect-memleak === Path: pummel/test-net-connect-memleak -64 kB reclaimed assert.js:102 throw new assert.AssertionError({ ^ AssertionError: false == true at done [as _onTimeout] (/home/bnoordhuis/src/nodejs/master/ test/pummel/test-net-connect-memleak.js:48:3) at Timer.listOnTimeout [as ontimeout] (timers.js:110:15) at process._makeCallback (node.js:306:20)	2013-01-27 22:01:14 +01:00
Ben Noordhuis	4cb17cb219	net: fix net.connect() resource leak The 'connect' event listener was attached with .on(), which blocked it from getting garbage collected. Use .once() instead. Fixes #4308.	2012-11-24 15:27:14 +01:00

Author

SHA1

Message

Date

Ben Noordhuis

98db7babcc

test: fix pummel/test-net-connect-memleak

* Run the garbage collector before creating the big array. It doesn't
  matter now but if in the future something in node.js core creates
  a lot of reclaimable garbage, that will break the test's expectation.

* The first RSS check was being done too late. The garbage collector
  might have run before the check, throwing off the 'reclaimed memory'
  calculation.

* Due to changes in how V8 represents the big array internally, the
  actual memory usage is just below 256 MB on x64. Update the test's
  expectation.

2013-08-01 16:07:46 +02:00

Ben Noordhuis

acd0df4ad9

test: fix pummel test out-of-memory errors

Fix the following OOM error in pummel/test-net-connect-memleak
and pummel/test-tls-connect-memleak:

  FATAL ERROR: CALL_AND_RETRY_0 Allocation failed - process out of
  memory

Commit v8/v8@91afd39 increases the size of the deoptimization table
to the extent that a 64M float array pushes it over the brink. Switch
to SMIs so it stays below the limit.

pummel/test-net-connect-memleak is still failing albeit with a different
error this time. Needs further investigation.

  === release test-net-connect-memleak ===
  Path: pummel/test-net-connect-memleak
  -64 kB reclaimed
  assert.js:102
    throw new assert.AssertionError({
          ^
  AssertionError: false == true
      at done [as _onTimeout] (/home/bnoordhuis/src/nodejs/master/
  test/pummel/test-net-connect-memleak.js:48:3)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
      at process._makeCallback (node.js:306:20)

2013-01-27 22:01:14 +01:00

Ben Noordhuis

4cb17cb219

net: fix net.connect() resource leak

The 'connect' event listener was attached with .on(), which blocked it from
getting garbage collected. Use .once() instead.

Fixes #4308.

2012-11-24 15:27:14 +01:00

3 Commits (e43c109891dcdce3da30de1baee1d2c97cabfcd9)