Commit Graph

42513 Commits (e8127db032d3b1a33400ed5d63611c65b8394ce5)

Author SHA1 Message Date
Khafra 6c85d40593
esm: use Undici/`fetch` `data:` URL parser
Fixes: https://github.com/nodejs/node/issues/53775
PR-URL: https://github.com/nodejs/node/pull/54748
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-07 10:22:03 +02:00
James M Snell dcc2ed944f src: move hkdf, scrypto, pbkdf2 impl to ncrypto
PR-URL: https://github.com/nodejs/node/pull/54651
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2024-09-06 19:44:26 -07:00
Yagiz Nizipli 16e6747c35 test: set `test-http2-socket-close` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:42 -07:00
Yagiz Nizipli 6d5a94b344 test: set `test-worker-arraybuffer-zerofill` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:41 -07:00
Yagiz Nizipli 1612f60161 test: set `test-runner-run-watch` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:39 -07:00
Yagiz Nizipli c45b7ec192 test: set `test-http-server-request-timeouts-mixed` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:38 -07:00
Yagiz Nizipli 67ccb3af17 test: set `test-single-executable-application-empty` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:36 -07:00
Yagiz Nizipli b002b62c95 test: set `test-macos-app-sandbox` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:35 -07:00
Yagiz Nizipli cfb128a2d9 test: set `test-fs-utimes` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:33 -07:00
Yagiz Nizipli f26c9bd3bc test: set `test-runner-run-watch` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:32 -07:00
Yagiz Nizipli 8ed9d54dfa test: set `test-sqlite-statement-sync` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:30 -07:00
Yagiz Nizipli e5c8978222 test: set `test-writewrap` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:29 -07:00
Yagiz Nizipli 407b61cec3 test: set `test-async-context-frame` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:27 -07:00
Yagiz Nizipli de238274d3 test: set `test-esm-loader-hooks-inspect-wait` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:25 -07:00
Yagiz Nizipli 9c6d6de828 test: set `test-http2-large-file` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:24 -07:00
Yagiz Nizipli affd1ced67 test: set `test-runner-watch-mode-complex` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:22 -07:00
Yagiz Nizipli 866d32ffcd test: set `test-performance-function` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:21 -07:00
Yagiz Nizipli c4c580bfd5 test: set `test-debugger-heap-profiler` as flaky
PR-URL: https://github.com/nodejs/node/pull/54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-06 17:02:19 -07:00
Guy Bedford c813de46fc
doc: mark `--conditions` CLI flag as stable
PR-URL: https://github.com/nodejs/node/pull/54209
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-07 01:37:19 +02:00
Node.js GitHub Bot 01bf4a1bee
deps: update cjs-module-lexer to 1.4.0
PR-URL: https://github.com/nodejs/node/pull/54713
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-06 22:41:00 +00:00
Tobias Nießen f061210819
doc: fix typo in recognizing-contributors
PR-URL: https://github.com/nodejs/node/pull/54822
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-09-06 22:31:12 +00:00
Huáng Jùnliàng 18101d83a1
crypto: reject dh,x25519,x448 in {Sign,Verify}Final
Fixes: https://github.com/nodejs/node/issues/53742
PR-URL: https://github.com/nodejs/node/pull/53774
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2024-09-06 22:07:16 +00:00
Aviv Keller c046c9b3d8
meta: add `Windows ARM64` to flaky-tests list
PR-URL: https://github.com/nodejs/node/pull/54693
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-06 18:59:08 +00:00
RafaelGSS 2f8d81ece3 benchmark: add buffer.isAscii benchmark
PR-URL: https://github.com/nodejs/node/pull/54740
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-06 17:46:49 +00:00
RafaelGSS 00291ea5dc benchmark: add buffer.isUtf8 bench
PR-URL: https://github.com/nodejs/node/pull/54740
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-06 17:46:49 +00:00
Jason Zhang 973144b7c6
lib: convert signals to array before validation
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54714
Fixes: https://github.com/nodejs/node/issues/54674
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-06 17:40:21 +00:00
Jason Zhang 1c67899ffb
buffer: fix out of range for toString
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/54553
Fixes: https://github.com/nodejs/node/issues/52298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-09-06 17:39:24 +00:00
Antoine du Hamel a75e3dff7e
test: fix `test-process-load-env-file` when path contains `'`
If the repo is cloned on a path that contains a quote, the test should
not fail.

PR-URL: https://github.com/nodejs/node/pull/54511
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-06 17:38:42 +00:00
Santiago Gimeno b345118e1e
test: refactor fs-watch tests due to macOS issue
In `macOS`, fsevents generated immediately before start watching may
leak into the event callback. See: https://github.com/nodejs/node/issues/54450
for an explanation. This might be fixed at some point in `libuv` though
it may take some time (see: https://github.com/libuv/libuv/issues/3866).
This commit comes in anticipation of the soon-to-be-released
`libuv@1.49.0` which was making these tests very flaky.

PR-URL: https://github.com/nodejs/node/pull/54498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-09-06 17:38:28 +00:00
Alexandre ABRIOUX bec80892b3
doc: clarify `--max-old-space-size` and `--max-semi-space-size` units
PR-URL: https://github.com/nodejs/node/pull/54477
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-09-06 19:33:03 +02:00
Aviv Keller 437e168c06
build: don't store eslint locally
PR-URL: https://github.com/nodejs/node/pull/54231
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-06 17:31:45 +00:00
M1CK431 b77476d884
doc: replace --allow-fs-read by --allow-fs-write in related section
PR-URL: https://github.com/nodejs/node/pull/54427
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-06 08:29:43 +00:00
Giovanni Bucci e4fdd0b492
test: refactor `test-esm-type-field-errors`
Co-Authored-By: Jacob Smith <jacob@frende.me>
PR-URL: https://github.com/nodejs/node/pull/54368
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-06 08:29:26 +00:00
1ilsang 94419bf64d
typings: fix TypedArray to a global type
PR-URL: https://github.com/nodejs/node/pull/54063
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-06 08:29:11 +00:00
Antoine du Hamel 13d6950a6c
tools: add util scripts to land and rebase PRs
PR-URL: https://github.com/nodejs/node/pull/54656
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2024-09-06 09:08:24 +02:00
Marco Ippolito b2dc908644
doc: add support link for marco-ippolito
PR-URL: https://github.com/nodejs/node/pull/54789
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-09-06 05:12:30 +00:00
Rafael Gonzaga 2c86f6a490
meta: ping @nodejs/performance on bench changes
PR-URL: https://github.com/nodejs/node/pull/54752
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2024-09-06 02:28:58 +00:00
Tobias Nießen 5fb9083b1a
doc: fix typo in module.md
PR-URL: https://github.com/nodejs/node/pull/54794
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2024-09-05 23:11:54 +00:00
Rafael Gonzaga 9441ce1c90
benchmark: add access async version to bench
PR-URL: https://github.com/nodejs/node/pull/54747
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2024-09-05 20:56:54 +00:00
Tobias Nießen 5a3c605d8c
sqlite: remove unnecessary auto assignment
Assignment is not necessary here at all.

PR-URL: https://github.com/nodejs/node/pull/54686
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-09-05 20:56:47 +00:00
Rafael Gonzaga fff1549551
benchmark: enhance dc publish benchmark
PR-URL: https://github.com/nodejs/node/pull/54745
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2024-09-05 20:21:24 +00:00
Rafael Gonzaga 143aca7d1f
lib: add note about removing `node:sys` module
PR-URL: https://github.com/nodejs/node/pull/54743
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-05 21:53:52 +02:00
Michael Dawson ce19715cbb deps: allow amaro to be externalizable
- allow amaro to be externalized like other builtins
  containing WASM. More context is available in
  https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/54646
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-05 14:27:30 -04:00
Joyee Cheung 24302c9fe9
doc: fix typo in CppgcMixin docs
PR-URL: https://github.com/nodejs/node/pull/54762
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-05 17:45:26 +00:00
Yagiz Nizipli 26eb062a9b
zlib: deprecate instantiating classes without new
PR-URL: https://github.com/nodejs/node/pull/54708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-05 16:25:33 +00:00
RafaelGSS 248d5e0dac benchmark: add match and doesNotMatch bench
PR-URL: https://github.com/nodejs/node/pull/54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-09-05 15:02:30 +00:00
RafaelGSS b26238132b benchmark: add rejects and doesNotReject bench
PR-URL: https://github.com/nodejs/node/pull/54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-09-05 15:02:29 +00:00
RafaelGSS 0b283c2b97 benchmark: add throws and doesNotThrow bench
PR-URL: https://github.com/nodejs/node/pull/54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-09-05 15:02:29 +00:00
RafaelGSS 688c885326 benchmark: add strictEqual and notStrictEqual bench
PR-URL: https://github.com/nodejs/node/pull/54734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-09-05 15:02:28 +00:00
Tim Perry 65b4fb840e
crypto: return a clearer error when loading an unsupported pkcs12
PR-URL: https://github.com/nodejs/node/pull/54485
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-05 14:15:01 +00:00