node/test
Anna Henningsen 87aa3f1add
http2: treat non-EOF empty frames like other invalid frames
Use the existing mechanism that we have to keep track of invalid frames
for treating this specific kind of invalid frame.

The commit that originally introduced this check was 695e38be69,
which was supposed to proected against CVE-2019-9518, which in turn
was specifically about a *flood* of empty data frames. While these are
still invalid frames either way, it makes sense to be forgiving here
and just treat them like other invalid frames, i.e. to allow a small
(configurable) number of them.

Fixes: https://github.com/nodejs/node/issues/37849

PR-URL: https://github.com/nodejs/node/pull/37875
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-03-26 20:51:57 +01:00
..
abort test: mark flaky tests on IBM i 2021-01-19 06:41:39 -08:00
addons test: make status file names consistent 2021-03-01 12:18:18 -08:00
async-hooks test: fix ibmi skip message 2021-03-22 10:56:05 -07:00
benchmark test: remove skip for fixed test-benchmark-fs 2021-03-21 08:26:14 -07:00
cctest test: fix typo in test_node_crypto.cc 2021-02-24 19:08:22 +05:30
common buffer: expose btoa and atob as globals 2021-03-25 08:12:52 -07:00
doctool doc,tools: use only one level 1 header per page 2021-03-25 11:23:58 -07:00
embedding
es-module module: runtime deprecate subpath folder mappings 2021-03-20 19:14:14 +01:00
fixtures http2: treat non-EOF empty frames like other invalid frames 2021-03-26 20:51:57 +01:00
fuzzers
internet
js-native-api node-api: define version 8 2021-03-10 16:31:16 -05:00
known_issues test: add known_issues test for #13683 2021-03-17 21:56:52 -07:00
message lib: aggregate errors to avoid error swallowing 2021-03-19 12:43:03 +01:00
node-api node-api: stop ref gc during environment teardown 2021-03-18 20:40:59 -07:00
overlapped-checker child_process: add 'overlapped' stdio flag 2021-01-03 22:40:50 +01:00
parallel http2: treat non-EOF empty frames like other invalid frames 2021-03-26 20:51:57 +01:00
pseudo-tty tty: validate file descriptor to avoid int32 overflow 2021-03-23 11:02:03 +01:00
pummel test: account for OOM risks in heapsnapshot-near-heap-limit tests 2021-03-20 12:38:23 -07:00
report
sequential test: fix flaky test-vm-timeout-escape-promise-module-2 2021-03-22 09:47:05 -07:00
testpy
tick-processor
tools
v8-updates
wasi test: fix wasi/test-return-on-exit on 32-bit systems 2021-03-08 05:53:04 -08:00
wpt test: app atob web platform tests 2021-03-18 12:04:15 -07:00
.eslintrc.yaml tools: make comma-dangle ESLint rule more stringent … 2021-02-19 09:55:38 -08:00
README.md
root.status

README.md

Node.js Core Tests

This directory contains code and data used to test the Node.js implementation.

For a detailed guide on how to write tests in this directory, see the guide on writing tests.

On how to run tests in this directory, see the contributing guide.

For the tests to run on Windows, be sure to clone Node.js source code with the autocrlf git config flag set to true.

Test Directories

Directory Runs on CI Purpose
abort Yes Tests for when the --abort-on-uncaught-exception flag is used.
addons Yes Tests for addon functionality along with some tests that require an addon.
async-hooks Yes Tests for async_hooks functionality.
benchmark Yes Test minimal functionality of benchmarks.
cctest Yes C++ tests that are run as part of the build process.
code-cache No Tests for a Node.js binary compiled with V8 code cache.
common Common modules shared among many tests. Documentation
doctool Yes Tests for the documentation generator.
es-module Yes Test ESM module loading.
fixtures Test fixtures used in various tests throughout the test suite.
internet No Tests that make real outbound network connections. Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.
js-native-api Yes Tests for Node.js-agnostic n-api functionality.
known_issues Yes Tests reproducing known issues within the system. All tests inside of this directory are expected to fail. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status.
message Yes Tests for messages that are output for various conditions (console.log, error messages etc.)
node-api Yes Tests for Node.js-specific n-api functionality.
parallel Yes Various tests that are able to be run in parallel.
pseudo-tty Yes Tests that require stdin/stdout/stderr to be a TTY.
pummel No Various tests for various modules / system functionality operating under load.
sequential Yes Various tests that must not run in parallel.
testpy Test configuration utility used by various test suites.
tick-processor No Tests for the V8 tick processor integration. The tests are for the logic in lib/internal/v8_prof_processor.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic.
v8-updates No Tests for V8 performance integration.