mirror of https://github.com/nodejs/node.git
d29f0eda15
Original commit message:
Make SetSyntheticModuleExport throw instead of crash for nonexistent export name
Per spec, Module::SetSyntheticModuleExport should throw a ReferenceError
when called with an export name that was not supplied when constructing
that SyntheticModule. Instead, the current implementation crashes with
a failed CHECK().
Add a new Module::SyntheticModuleSetExport that throws (without an ensuing
crash) for this case, and deprecate the old
Module::SetSyntheticModuleExport.
Bug: v8:9828
Change-Id: I3b3d353064c3851882781818099bd8f6ee74c809
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1860996
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#64438}
Refs:
|
||
|---|---|---|
| .. | ||
| acorn | ||
| acorn-plugins | ||
| brotli | ||
| cares | ||
| histogram | ||
| icu-small | ||
| llhttp | ||
| nghttp2 | ||
| node-inspect | ||
| npm | ||
| openssl | ||
| uv | ||
| v8 | ||
| zlib | ||