From 0841e1d78b447a24966b9488e7c9014ec53d5566 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 2 Jan 2019 13:51:49 -0800 Subject: [PATCH] Remove terminal.integrated.experimentalBufferImpl Part of #63688 --- .../terminal/electron-browser/terminal.contribution.ts | 6 ------ .../parts/terminal/electron-browser/terminalInstance.ts | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts index 9c0a95a96d1..7bbe871a70e 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts @@ -380,12 +380,6 @@ configurationRegistry.registerConfiguration({ type: 'boolean', default: true }, - 'terminal.integrated.experimentalBufferImpl': { - description: nls.localize('terminal.integrated.experimentalBufferImpl', "Controls the terminal's internal buffer implementation. This setting is picked up on terminal creation and will not apply to existing terminals."), - type: 'string', - enum: ['JsArray', 'TypedArray'], - default: 'TypedArray' - }, 'terminal.integrated.splitCwd': { description: nls.localize('terminal.integrated.splitCwd', "Controls the working directory a split terminal starts with."), type: 'string', diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts b/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts index 1ecfde7af35..33dfaefb86d 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts @@ -312,7 +312,7 @@ export class TerminalInstance implements ITerminalInstance { rendererType: config.rendererType === 'auto' ? 'canvas' : config.rendererType, // TODO: Remove this once the setting is removed upstream experimentalCharAtlas: 'dynamic', - experimentalBufferLineImpl: config.experimentalBufferImpl + experimentalBufferLineImpl: 'TypedArray' }); if (this._shellLaunchConfig.initialText) { this._xterm.writeln(this._shellLaunchConfig.initialText);