From 12eb715644f428a65f685ccda30e6d847a545a50 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Thu, 2 Jan 2020 21:12:03 +0100 Subject: [PATCH] (re)enable no-extra-semi rule --- .eslintrc.json | 2 +- extensions/vscode-colorize-tests/src/colorizer.test.ts | 2 +- .../test/electron-browser/api/extHostDiagnostics.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index bc2ea028862..350c4751033 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -19,7 +19,7 @@ "no-duplicate-case": "warn", "no-duplicate-imports": "warn", "no-eval": "warn", - "no-extra-semi": "off", + "no-extra-semi": "warn", "no-new-wrappers": "warn", "no-redeclare": "off", "no-sparse-arrays": "warn", diff --git a/extensions/vscode-colorize-tests/src/colorizer.test.ts b/extensions/vscode-colorize-tests/src/colorizer.test.ts index 82892577bdf..28a992573b9 100644 --- a/extensions/vscode-colorize-tests/src/colorizer.test.ts +++ b/extensions/vscode-colorize-tests/src/colorizer.test.ts @@ -56,7 +56,7 @@ function hasThemeChange(d: any, p: any) : boolean { } } return false; -}; +} suite('colorization', () => { let extensionsFolder = normalize(join(__dirname, '../../')); diff --git a/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts b/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts index 374f21e78d0..6a1852d8990 100644 --- a/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts +++ b/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts @@ -34,7 +34,7 @@ suite('ExtHostDiagnostics', () => { assert.throws(() => collection.clear()); assert.throws(() => collection.delete(URI.parse('aa:bb'))); // tslint:disable-next-line:semicolon - assert.throws(() => collection.forEach(() => { ; })); + assert.throws(() => collection.forEach(() => { })); assert.throws(() => collection.get(URI.parse('aa:bb'))); assert.throws(() => collection.has(URI.parse('aa:bb'))); assert.throws(() => collection.set(URI.parse('aa:bb'), []));