From 392373943fe80b1293e31872f4971046d7f49e67 Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Wed, 2 Jan 2019 17:56:42 -0800 Subject: [PATCH] Settings editor - ObjectTree is already disposable --- src/vs/workbench/parts/preferences/browser/settingsTree.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/vs/workbench/parts/preferences/browser/settingsTree.ts b/src/vs/workbench/parts/preferences/browser/settingsTree.ts index b0f6eb9d770..4f64c52040e 100644 --- a/src/vs/workbench/parts/preferences/browser/settingsTree.ts +++ b/src/vs/workbench/parts/preferences/browser/settingsTree.ts @@ -1343,8 +1343,6 @@ class NonCollapsibleObjectTreeModel extends ObjectTreeModel { } export class SettingsTree extends ObjectTree { - protected disposables: IDisposable[]; - constructor( container: HTMLElement, viewState: ISettingsEditorViewState, @@ -1439,10 +1437,6 @@ export class SettingsTree extends ObjectTree { protected createModel(view: ISpliceable>, options: IObjectTreeOptions): ITreeModel { return new NonCollapsibleObjectTreeModel(view, options); } - - public dispose(): void { - this.disposables = dispose(this.disposables); - } } class CopySettingIdAction extends Action {