address feedback

pull/179269/head
Sandeep Somavarapu 2023-04-05 18:05:02 +02:00
parent 6e99e8a826
commit 4370b66e75
No known key found for this signature in database
GPG Key ID: DD41CAAC8081CC7D
4 changed files with 3 additions and 3 deletions

1
.gitignore vendored
View File

@ -16,3 +16,4 @@ vscode.lsif
vscode.db
/.profile-oss
/cli/target
product.overrides.json

View File

@ -1 +0,0 @@
{}

View File

@ -19,7 +19,7 @@ globalThis._VSCODE_NODE_MODULES = new Proxy(Object.create(null), { get: (_target
let product = require('../product.json');
if (process.env['VSCODE_DEV']) {
// Patch product overrides when running out of sources
product = Object.assign(product, require('../product.overrides.json'));
try { product = Object.assign(product, require(require('path').join(__dirname, '../product.overrides.json'))); } catch (error) { /* ignore */ }
}
globalThis._VSCODE_PRODUCT_JSON = product;
globalThis._VSCODE_PACKAGE_JSON = require('../package.json');

View File

@ -120,7 +120,7 @@
let product = (require.__$__nodeRequire ?? require)(configuration.appRoot + '/product.json');
if (process.env['VSCODE_DEV']) {
// Patch product overrides when running out of sources
product = Object.assign(product, (require.__$__nodeRequire ?? require)(configuration.appRoot + '/product.overrides.json'));
try { product = Object.assign(product, (require.__$__nodeRequire ?? require)(configuration.appRoot + '/product.overrides.json')); } catch (error) { /* ignore */ }
}
globalThis._VSCODE_PRODUCT_JSON = product;
globalThis._VSCODE_PACKAGE_JSON = (require.__$__nodeRequire ?? require)(configuration.appRoot + '/package.json');