daohualiuxiang
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: don't leak listener in share contribution (#236767)

pull/199784/merge
Joyce Er 2024-12-20 20:22:20 -08:00 committed by GitHub
parent 13d2a615cb
commit 68252d3d7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/vs/workbench/contrib/share/browser/share.contribution.ts
View File

@ -32,7 +32,7 @@ import { IProgressService, ProgressLocation } from '../../../../platform/progres
import { ICodeEditorService } from '../../../../editor/browser/services/codeEditorService.js';
import { IConfigurationRegistry, Extensions as ConfigurationExtensions } from '../../../../platform/configuration/common/configurationRegistry.js';
import { workbenchConfigurationNodeBase } from '../../../common/configuration.js';
import { DisposableStore } from '../../../../base/common/lifecycle.js';
import { Disposable, DisposableStore } from '../../../../base/common/lifecycle.js';
const targetMenus = [
MenuId.EditorContextShare,
@ -44,7 +44,7 @@ const targetMenus = [
MenuId.ExplorerContextShare
];
class ShareWorkbenchContribution {
class ShareWorkbenchContribution extends Disposable {
private static SHARE_ENABLED_SETTING = 'workbench.experimental.share.enabled';
private _disposables: DisposableStore | undefined;
@ -53,10 +53,12 @@ class ShareWorkbenchContribution {
@IShareService private readonly shareService: IShareService,
@IConfigurationService private readonly configurationService: IConfigurationService
) {
super();
if (this.configurationService.getValue<boolean>(ShareWorkbenchContribution.SHARE_ENABLED_SETTING)) {
this.registerActions();
}
this.configurationService.onDidChangeConfiguration(e => {
this._register(this.configurationService.onDidChangeConfiguration(e => {
if (e.affectsConfiguration(ShareWorkbenchContribution.SHARE_ENABLED_SETTING)) {
const settingValue = this.configurationService.getValue<boolean>(ShareWorkbenchContribution.SHARE_ENABLED_SETTING);
if (settingValue === true && this._disposables === undefined) {
@ -66,7 +68,12 @@ class ShareWorkbenchContribution {
this._disposables = undefined;
}
}
});
}));
}
override dispose(): void {
super.dispose();
this._disposables?.dispose();
}
private registerActions() {