diff --git a/extensions/github-authentication/src/github.ts b/extensions/github-authentication/src/github.ts index 9deaef3000b..6d5b042ac0c 100644 --- a/extensions/github-authentication/src/github.ts +++ b/extensions/github-authentication/src/github.ts @@ -213,7 +213,9 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid /* __GDPR__ "login" : { - "scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } + "owner": "TylerLeonhardt", + "comment": "Used to determine how much usage the GitHub Auth Provider gets.", + "scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight", "comment": "Used to determine what scope combinations are being requested." } } */ this._telemetryReporter?.sendTelemetryEvent('login', { @@ -244,14 +246,14 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid // If login was cancelled, do not notify user. if (e === 'Cancelled' || e.message === 'Cancelled') { /* __GDPR__ - "loginCancelled" : { } + "loginCancelled" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users cancel the login flow." } */ this._telemetryReporter?.sendTelemetryEvent('loginCancelled'); throw e; } /* __GDPR__ - "loginFailed" : { } + "loginFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users run into an error login flow." } */ this._telemetryReporter?.sendTelemetryEvent('loginFailed'); @@ -274,7 +276,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid public async removeSession(id: string) { try { /* __GDPR__ - "logout" : { } + "logout" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users log out of an account." } */ this._telemetryReporter?.sendTelemetryEvent('logout'); @@ -294,7 +296,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid } } catch (e) { /* __GDPR__ - "logoutFailed" : { } + "logoutFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often logging out of an account fails." } */ this._telemetryReporter?.sendTelemetryEvent('logoutFailed'); diff --git a/extensions/microsoft-authentication/src/extension.ts b/extensions/microsoft-authentication/src/extension.ts index 06a2facdf13..3ca8eb91e1e 100644 --- a/extensions/microsoft-authentication/src/extension.ts +++ b/extensions/microsoft-authentication/src/extension.ts @@ -21,7 +21,9 @@ export async function activate(context: vscode.ExtensionContext) { try { /* __GDPR__ "login" : { - "scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } + "owner": "TylerLeonhardt", + "comment": "Used to determine the usage of the Microsoft Auth Provider.", + "scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight", "comment": "Used to determine what scope combinations are being requested." } } */ telemetryReporter.sendTelemetryEvent('login', { @@ -34,7 +36,7 @@ export async function activate(context: vscode.ExtensionContext) { return session; } catch (e) { /* __GDPR__ - "loginFailed" : { } + "loginFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users run into issues with the login flow." } */ telemetryReporter.sendTelemetryEvent('loginFailed'); @@ -44,7 +46,7 @@ export async function activate(context: vscode.ExtensionContext) { removeSession: async (id: string) => { try { /* __GDPR__ - "logout" : { } + "logout" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users log out." } */ telemetryReporter.sendTelemetryEvent('logout'); @@ -54,7 +56,7 @@ export async function activate(context: vscode.ExtensionContext) { } } catch (e) { /* __GDPR__ - "logoutFailed" : { } + "logoutFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often fail to log out." } */ telemetryReporter.sendTelemetryEvent('logoutFailed'); } diff --git a/src/vs/workbench/api/browser/mainThreadAuthentication.ts b/src/vs/workbench/api/browser/mainThreadAuthentication.ts index 85789a816ec..b72301f5f28 100644 --- a/src/vs/workbench/api/browser/mainThreadAuthentication.ts +++ b/src/vs/workbench/api/browser/mainThreadAuthentication.ts @@ -274,8 +274,10 @@ export class MainThreadAuthentication extends Disposable implements MainThreadAu if (session) { type AuthProviderUsageClassification = { - extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; - providerId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; + owner: 'TylerLeonhardt'; + comment: 'Used to see which extensions are using which providers'; + extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The extension id.' }; + providerId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The provider id.' }; }; this.telemetryService.publicLog2<{ extensionId: string; providerId: string }, AuthProviderUsageClassification>('authentication.providerUsage', { providerId, extensionId }); diff --git a/src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts b/src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts index 199b0d8217a..36ffefdd42c 100644 --- a/src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts +++ b/src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts @@ -42,10 +42,12 @@ export interface IAutomaticLanguageDetectionLikelyWrongData { } export type AutomaticLanguageDetectionLikelyWrongClassification = { - currentLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; - nextLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; - lineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true }; - modelPreference: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; + owner: 'TylerLeonhardt,JacksonKearl'; + comment: 'Used to determine how often language detection is likely wrong.'; + currentLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The language id we guessed.' }; + nextLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The language id the user chose.' }; + lineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'The number of lines in the file.' }; + modelPreference: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'What the user\'s model preference is.' }; }; export const LanguageDetectionStatsId = 'automaticlanguagedetection.stats'; @@ -57,9 +59,11 @@ export interface ILanguageDetectionStats { } export type LanguageDetectionStatsClassification = { - languages: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; - confidences: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; - timeSpent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; + owner: 'TylerLeonhardt,JacksonKearl'; + comment: 'Used to determine how definitive language detection is and how long it takes.'; + languages: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The languages the model supports.' }; + confidences: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The confidences of those languages.' }; + timeSpent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'How long the operation took.' }; }; //#endregion