daohualiuxiang
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add owner and comment to some telemetry events (#148752)

pull/148940/head
Tyler James Leonhardt 2022-05-05 14:30:51 -07:00 committed by GitHub
parent 2623225b18
commit 847629239b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/github-authentication/src/github.ts
View File

@ -213,7 +213,9 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
/* __GDPR__ /* __GDPR__
"login" : { "login" : {
"scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } "owner": "TylerLeonhardt",
"comment": "Used to determine how much usage the GitHub Auth Provider gets.",
"scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight", "comment": "Used to determine what scope combinations are being requested." }
} }
*/ */
this._telemetryReporter?.sendTelemetryEvent('login', { this._telemetryReporter?.sendTelemetryEvent('login', {
@ -244,14 +246,14 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
// If login was cancelled, do not notify user. // If login was cancelled, do not notify user.
if (e === 'Cancelled' || e.message === 'Cancelled') { if (e === 'Cancelled' || e.message === 'Cancelled') {
/* __GDPR__ /* __GDPR__
"loginCancelled" : { } "loginCancelled" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users cancel the login flow." }
*/ */
this._telemetryReporter?.sendTelemetryEvent('loginCancelled'); this._telemetryReporter?.sendTelemetryEvent('loginCancelled');
throw e; throw e;
} }
/* __GDPR__ /* __GDPR__
"loginFailed" : { } "loginFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users run into an error login flow." }
*/ */
this._telemetryReporter?.sendTelemetryEvent('loginFailed'); this._telemetryReporter?.sendTelemetryEvent('loginFailed');
@ -274,7 +276,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
public async removeSession(id: string) { public async removeSession(id: string) {
try { try {
/* __GDPR__ /* __GDPR__
"logout" : { } "logout" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users log out of an account." }
*/ */
this._telemetryReporter?.sendTelemetryEvent('logout'); this._telemetryReporter?.sendTelemetryEvent('logout');
@ -294,7 +296,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
} }
} catch (e) { } catch (e) {
/* __GDPR__ /* __GDPR__
"logoutFailed" : { } "logoutFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often logging out of an account fails." }
*/ */
this._telemetryReporter?.sendTelemetryEvent('logoutFailed'); this._telemetryReporter?.sendTelemetryEvent('logoutFailed');

10
extensions/microsoft-authentication/src/extension.ts
View File

@ -21,7 +21,9 @@ export async function activate(context: vscode.ExtensionContext) {
try { try {
/* __GDPR__ /* __GDPR__
"login" : { "login" : {
"scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } "owner": "TylerLeonhardt",
"comment": "Used to determine the usage of the Microsoft Auth Provider.",
"scopes": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight", "comment": "Used to determine what scope combinations are being requested." }
} }
*/ */
telemetryReporter.sendTelemetryEvent('login', { telemetryReporter.sendTelemetryEvent('login', {
@ -34,7 +36,7 @@ export async function activate(context: vscode.ExtensionContext) {
return session; return session;
} catch (e) { } catch (e) {
/* __GDPR__ /* __GDPR__
"loginFailed" : { } "loginFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users run into issues with the login flow." }
*/ */
telemetryReporter.sendTelemetryEvent('loginFailed'); telemetryReporter.sendTelemetryEvent('loginFailed');
@ -44,7 +46,7 @@ export async function activate(context: vscode.ExtensionContext) {
removeSession: async (id: string) => { removeSession: async (id: string) => {
try { try {
/* __GDPR__ /* __GDPR__
"logout" : { } "logout" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often users log out." }
*/ */
telemetryReporter.sendTelemetryEvent('logout'); telemetryReporter.sendTelemetryEvent('logout');
@ -54,7 +56,7 @@ export async function activate(context: vscode.ExtensionContext) {
} }
} catch (e) { } catch (e) {
/* __GDPR__ /* __GDPR__
"logoutFailed" : { } "logoutFailed" : { "owner": "TylerLeonhardt", "comment": "Used to determine how often fail to log out." }
*/ */
telemetryReporter.sendTelemetryEvent('logoutFailed'); telemetryReporter.sendTelemetryEvent('logoutFailed');
} }

6
src/vs/workbench/api/browser/mainThreadAuthentication.ts
View File

@ -274,8 +274,10 @@ export class MainThreadAuthentication extends Disposable implements MainThreadAu
if (session) { if (session) {
type AuthProviderUsageClassification = { type AuthProviderUsageClassification = {
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; owner: 'TylerLeonhardt';
providerId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; comment: 'Used to see which extensions are using which providers';
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The extension id.' };
providerId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The provider id.' };
}; };
this.telemetryService.publicLog2<{ extensionId: string; providerId: string }, AuthProviderUsageClassification>('authentication.providerUsage', { providerId, extensionId }); this.telemetryService.publicLog2<{ extensionId: string; providerId: string }, AuthProviderUsageClassification>('authentication.providerUsage', { providerId, extensionId });

18
src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts
View File

@ -42,10 +42,12 @@ export interface IAutomaticLanguageDetectionLikelyWrongData {
} }
export type AutomaticLanguageDetectionLikelyWrongClassification = { export type AutomaticLanguageDetectionLikelyWrongClassification = {
currentLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; owner: 'TylerLeonhardt,JacksonKearl';
nextLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; comment: 'Used to determine how often language detection is likely wrong.';
lineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true }; currentLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The language id we guessed.' };
modelPreference: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; nextLanguageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The language id the user chose.' };
lineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'The number of lines in the file.' };
modelPreference: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'What the user\'s model preference is.' };
}; };
export const LanguageDetectionStatsId = 'automaticlanguagedetection.stats'; export const LanguageDetectionStatsId = 'automaticlanguagedetection.stats';
@ -57,9 +59,11 @@ export interface ILanguageDetectionStats {
} }
export type LanguageDetectionStatsClassification = { export type LanguageDetectionStatsClassification = {
languages: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; owner: 'TylerLeonhardt,JacksonKearl';
confidences: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; comment: 'Used to determine how definitive language detection is and how long it takes.';
timeSpent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' }; languages: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The languages the model supports.' };
confidences: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The confidences of those languages.' };
timeSpent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'How long the operation took.' };
}; };
//#endregion //#endregion