From b31895076ed15eb452a6654b0b2a807ffbe222bf Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 3 Jan 2019 20:11:28 -0800 Subject: [PATCH] Disable conpty by default - Cursor flickering in powershell is _really_ annoying and there is no way to work around it reliably. It's happening because conpty hides and shows the cursor many times when it doesn't really need to, and since data isn't batched xterm.js renders as much as possible which shows the cursor in positions. - Kill doesn't kill the process, this is likely a problem on our end. Part of #66001 --- .../parts/terminal/electron-browser/terminal.contribution.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts index 7bbe871a70e..bb65b1b7914 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts @@ -392,9 +392,9 @@ configurationRegistry.registerConfiguration({ default: 'inherited' }, 'terminal.integrated.windowsEnableConpty': { - description: nls.localize('terminal.integrated.windowsEnableConpty', "Whether to use ConPTY for Windows terminal process communication (requires Windows 10 build number 17692+). The default is to enable this on Windows 10 build number 17692+. Winpty will be used if this is false."), + description: nls.localize('terminal.integrated.windowsEnableConpty', "Whether to use ConPTY for Windows terminal process communication (requires Windows 10 build number 17692+). Winpty will be used if this is false."), type: 'boolean', - default: true + default: false } } });