daohualiuxiang
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

git: validate URI for clone command (#149180) 

Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
pull/149194/head
Joyce Er 2022-05-10 11:32:02 -07:00 committed by GitHub
parent 8965a02114
commit c5da5332d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
extensions/git/src/protocolHandler.ts
View File

@ -7,6 +7,8 @@ import { UriHandler, Uri, window, Disposable, commands } from 'vscode';
import { dispose } from './util';
import * as querystring from 'querystring';
const schemes = new Set(['file', 'git', 'http', 'https', 'ssh']);
export class GitProtocolHandler implements UriHandler {
private disposables: Disposable[] = [];
@ -26,9 +28,27 @@ export class GitProtocolHandler implements UriHandler {
if (!data.url) {
console.warn('Failed to open URI:', uri);
return;
}
commands.executeCommand('git.clone', data.url);
if (Array.isArray(data.url) && data.url.length === 0) {
console.warn('Failed to open URI:', uri);
return;
}
let cloneUri: Uri;
try {
cloneUri = Uri.parse(Array.isArray(data.url) ? data.url[0] : data.url, true);
if (!schemes.has(cloneUri.scheme.toLowerCase())) {
throw new Error('Unsupported scheme.');
}
}
catch (ex) {
console.warn('Invalid URI:', uri);
return;
}
commands.executeCommand('git.clone', cloneUri.toString(true));
}
dispose(): void {