daohualiuxiang
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

debt - go over todos (#235924) 

* debt - go over todos

* fix hygiene
pull/235951/head
Benjamin Pasero 2024-12-12 14:47:59 +01:00 committed by GitHub
parent a05c4434d7
commit f6e97b7c97
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 18 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build/lib/inlineMeta.js
View File

@ -8,7 +8,7 @@ exports.inlineMeta = inlineMeta;
const es = require("event-stream");
const path_1 = require("path");
const packageJsonMarkerId = 'BUILD_INSERT_PACKAGE_CONFIGURATION';
// TODO@bpasero in order to inline `product.json`, more work is
// TODO in order to inline `product.json`, more work is
// needed to ensure that we cover all cases where modifications
// are done to the product configuration during build. There are
// at least 2 more changes that kick in very late:

2
build/lib/inlineMeta.ts
View File

@ -15,7 +15,7 @@ export interface IInlineMetaContext {
const packageJsonMarkerId = 'BUILD_INSERT_PACKAGE_CONFIGURATION';
// TODO@bpasero in order to inline `product.json`, more work is
// TODO in order to inline `product.json`, more work is
// needed to ensure that we cover all cases where modifications
// are done to the product configuration during build. There are
// at least 2 more changes that kick in very late:

6
src/vs/platform/auxiliaryWindow/electron-main/auxiliaryWindow.ts
View File

@ -62,9 +62,9 @@ export class AuxiliaryWindow extends BaseWindow implements IAuxiliaryWindow {
y: options.y,
width: options.width,
height: options.height,
// TODO@bpasero We currently do not support restoring fullscreen state for
// auxiliary windows because we do not get hold of the original `features`
// string that contains that info in `window-fullscreen`. However, we can
// We currently do not support restoring fullscreen state for auxiliary
// windows because we do not get hold of the original `features` string
// that contains that info in `window-fullscreen`. However, we can
// probe the `options.show` value for whether the window should be maximized
// or not because we never show maximized windows initially to reduce flicker.
mode: options.show === false ? WindowMode.Maximized : WindowMode.Normal

8
src/vs/platform/files/node/watcher/nodejs/nodejsWatcherLib.ts
View File

@ -147,10 +147,10 @@ export class NodeJSFileWatcherLibrary extends Disposable {
private doWatchWithExistingWatcher(realPath: string, isDirectory: boolean, disposables: DisposableStore): boolean {
if (isDirectory) {
// TODO@bpasero recursive watcher re-use is currently not enabled
// for when folders are watched. this is because the dispatching
// in the recursive watcher for non-recurive requests is optimized
// for file changes where we really only match on the exact path
// Recursive watcher re-use is currently not enabled for when
// folders are watched. this is because the dispatching in the
// recursive watcher for non-recurive requests is optimized for
// file changes where we really only match on the exact path
// and not child paths.
return false;
}

5
src/vs/workbench/browser/layout.ts
View File

@ -707,11 +707,8 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
// Auxiliary Panel to restore
if (this.isVisible(Parts.AUXILIARYBAR_PART)) {
let viewContainerToRestore = this.storageService.get(AuxiliaryBarPart.activePanelSettingsKey, StorageScope.WORKSPACE, this.viewDescriptorService.getDefaultViewContainer(ViewContainerLocation.AuxiliaryBar)?.id);
const viewContainerToRestore = this.storageService.get(AuxiliaryBarPart.activePanelSettingsKey, StorageScope.WORKSPACE, this.viewDescriptorService.getDefaultViewContainer(ViewContainerLocation.AuxiliaryBar)?.id);
if (viewContainerToRestore) {
if (viewContainerToRestore === 'workbench.panel.chatSidebar') {
viewContainerToRestore = 'workbench.panel.chat'; // TODO@bpasero remove me after some months
}
this.state.initialization.views.containerToRestore.auxiliaryBar = viewContainerToRestore;
} else {
this.stateModel.setRuntimeValue(LayoutStateKeys.AUXILIARYBAR_HIDDEN, true);

2
src/vs/workbench/browser/parts/titlebar/titlebarActions.ts
View File

@ -259,7 +259,7 @@ registerAction2(class ToggleEditorActions extends Action2 {
}
});
if (isLinux && isNative) { // TODO@bpasero remove me later
if (isLinux && isNative) {
registerAction2(class ToggleCustomTitleBar extends Action2 {
constructor() {
super({

2
src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts
View File

@ -813,7 +813,7 @@ export class DynamicSpeechAccessibilityConfiguration extends Disposable implemen
localize('accessibility.voice.autoSynthesize.auto', "When a screen reader is detected, disable the feature. Otherwise, enable the feature.")
],
'markdownDescription': localize('autoSynthesize', "Whether a textual response should automatically be read out aloud when speech was used as input. For example in a chat session, a response is automatically synthesized when voice was used as chat request."),
'default': this.productService.quality !== 'stable' ? 'auto' : 'off', // TODO@bpasero decide on a default
'default': this.productService.quality !== 'stable' ? 'auto' : 'off',
'tags': ['accessibility']
}
}

4
src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts
View File

@ -373,7 +373,7 @@ class VoiceChatSessions {
if (autoSynthesize === 'on' || autoSynthesize === 'auto' && !this.accessibilityService.isScreenReaderOptimized()) {
let context: IVoiceChatSessionController | 'focused';
if (controller.context === 'inline') {
// TODO@bpasero this is ugly, but the lightweight inline chat turns into
// This is ugly, but the lightweight inline chat turns into
// a different widget as soon as a response comes in, so we fallback to
// picking up from the focused chat widget
context = 'focused';
@ -695,7 +695,7 @@ class ChatSynthesizerSessionController {
const contextKeyService = accessor.get(IContextKeyService);
let chatWidget = chatWidgetService.getWidgetBySessionId(response.session.sessionId);
if (chatWidget?.location === ChatAgentLocation.Editor) {
// TODO@bpasero workaround for https://github.com/microsoft/vscode/issues/212785
// workaround for https://github.com/microsoft/vscode/issues/212785
chatWidget = chatWidgetService.lastFocusedWidget;
}

6
src/vs/workbench/contrib/multiDiffEditor/browser/multiDiffEditorInput.ts
View File

@ -280,9 +280,9 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
override readonly closeHandler: IEditorCloseHandler = {
// TODO@bpasero TODO@hediet this is a workaround for
// not having a better way to figure out if the
// editors this input wraps around are opened or not
// This is a workaround for not having a better way
// to figure out if the editors this input wraps
// around are opened or not
async confirm() {
return ConfirmResult.DONT_SAVE;

2
src/vs/workbench/contrib/output/browser/outputView.ts
View File

@ -164,7 +164,7 @@ class OutputEditor extends AbstractTextResourceEditor {
@IEditorService editorService: IEditorService,
@IFileService fileService: IFileService
) {
super(OUTPUT_VIEW_ID, editorGroupService.activeGroup /* TODO@bpasero this is wrong */, telemetryService, instantiationService, storageService, textResourceConfigurationService, themeService, editorGroupService, editorService, fileService);
super(OUTPUT_VIEW_ID, editorGroupService.activeGroup /* this is not correct but pragmatic */, telemetryService, instantiationService, storageService, textResourceConfigurationService, themeService, editorGroupService, editorService, fileService);
this.resourceContext = this._register(instantiationService.createInstance(ResourceContextKey));
}