Commit Graph

1758 Commits (main)

Author SHA1 Message Date
Aiday Marlen Kyzy 3958e26f65
Enable edit context (#235386)
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1c6f.

* adding product import
2025-01-07 10:00:03 +01:00
Johannes Rieken 17f6bcb7d2
chore - modernise test runner (#235511)
async/wait, remove AMD/ESM split, cleanup
2024-12-06 18:53:29 +01:00
Aiday Marlen Kyzy 45385e1c6f
Revert Enablement of EditContext on Insiders (#235062)
Revert "Reenabling EditContext by default on Insiders (#234888)"

This reverts commit a47f407e38.
2024-12-03 08:37:57 +01:00
Aiday Marlen Kyzy a47f407e38
Reenabling EditContext by default on Insiders (#234888)
Revert "Revert "Smoke test failure - changing selectors depending on app qual…"

This reverts commit b8d5339e04.
2024-11-29 11:49:50 +01:00
Johannes Rieken 1994ebabef
tweak inline chat hint (#234821)
* make editor readonly and disable squiggle while inline chat shows reply

https://github.com/microsoft/vscode/issues/226160

* tweak inline chat hint

only show on intented empty lines, hide when command run

* fix tests (only disable squiggle, not readonlyness)
2024-11-28 12:58:47 +01:00
Johannes Rieken e45ebc6d59
fail tests when having unhandled errors (#234673) 2024-11-26 08:32:08 -08:00
Aiday Marlen Kyzy b8d5339e04
Revert "Smoke test failure - changing selectors depending on app quality" (#234638)
Revert "Smoke test failure - changing selectors depending on app quality (#23…"

This reverts commit b69589ce38.
2024-11-26 09:17:31 +01:00
Aiday Marlen Kyzy b69589ce38
Smoke test failure - changing selectors depending on app quality (#234181)
* changing selector depending on app quality smoke test

* using correct selector

* resetting to just insiders

* focusing if not focused after event

* removing dom node focus
2024-11-21 11:58:33 +01:00
Aiday Marlen Kyzy 8d1d1373cd
Reverting EditContext changes (#234247)
reverting changes
2024-11-20 10:18:20 +01:00
Aiday Marlen Kyzy d649101bec
Turning on experimental edit context on Insiders (#234071)
* turning on experimental edit context on insiders

* fixing smoke test

* resetting the search input to use the textarea
2024-11-19 10:19:00 +01:00
Robo e178455531
ci: check for clean git state in npm validation (#230479) 2024-10-04 11:04:18 -07:00
Benjamin Pasero c5b6ef14e6
esm - more cleanup (#230285) 2024-10-02 11:55:17 +02:00
Benjamin Pasero f09184ceb7
esm - set `type: module` top level (#230210) 2024-10-01 20:48:56 +02:00
Benjamin Pasero 3b68a06818
esm - removal of CSS loader (#230206) 2024-10-01 19:24:18 +02:00
Benjamin Pasero 332b89f198
esm - remove AMD build scripts, tests and variables 2024-09-27 08:04:01 +02:00
Benjamin Pasero 789c320a1c
Replace mkdirp with fs.mkdirSync(path, { recursive: true }) (#228017)
* Replace mkdirp with fs.mkdirSync(path, { recursive: true })
(fix #227931)

* compile
2024-09-09 22:43:29 -07:00
dependabot[bot] 2a4d7851ef
Bump pathval from 1.1.0 to 1.1.1 in /test/monaco (#227783)
Bumps [pathval](https://github.com/chaijs/pathval) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases)
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md)
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: pathval
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-07 11:43:31 +09:00
Robo b5a6aa14a8
feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Sandeep Somavarapu ebc02af2d8
rename electron-node to electron-utility (#227672) 2024-09-05 00:49:23 -07:00
Sandeep Somavarapu 01fcf004a6
Use electron net directly in shared process (#227553)
* Use electron net directly in shared process

* add built file

* introduce shared electron-node layer

* remove electron-utility layer

* fix (overlook): move back cli files to node
2024-09-04 07:26:43 -07:00
Connor Peet f9877b1978
eng: re-add coverage support post-ESM (#227459)
Fixes #227432
2024-09-03 20:33:56 +02:00
Benjamin Pasero d60295dc0e
ESM: revisit need for `_VSCODE_NODE_MODULES` (fix #226453) (#227427) 2024-09-03 15:18:08 +02:00
Benjamin Pasero ca42f649a7
Allow to build an AMD version of VS Code (#227240) 2024-09-02 09:36:19 +02:00
Benjamin Pasero f0417069c6
esm - restore lost changes in tests from migration (#227225) 2024-08-30 09:12:48 -07:00
Benjamin Pasero 6b924c5152
ESM merge to main (#227184)
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-08-30 10:31:46 +02:00
Benjamin Pasero 9f04aaf6f4
tests - depend on a test preload.js (#226588) 2024-08-26 10:14:27 +02:00
Alexandru Dima 4e0de3a8f4
Move workbench workers off EditorWorker (#225796)
* Add support for having channels in SimpleWorker

* Extract text model syncing code to a separate file

* Use a channel to do text model syncing for the language detection worker

* Simplify code

* Remove unused method

* Move OutputLinkComputer worker off editor worker

* Move TextMateTokenizationWorker off editor worker

* Simplify code

* Adopt channels for the host object

* More adopting channels for the host object

* More adopting channels for the host object

* More adopting channels for the host object

* Remove host object support from SimpleWorker

* Use the IEditorWorkerService, avoid starting a separate worker

* Bring the amd module id, the esm location and the worker label in a single type

* Improve typings

* SImplify worker creation pattern

* Enforce that all proxied methods start with `$` or `on`

* Adopt native proxy support

* Simplify code

* Simplify code

* Reintroduce a different standalone / workbench editor worker service
2024-08-20 14:00:18 +02:00
Benjamin Pasero 48bf32d320
esm - fix browser tests to run (#225791) 2024-08-16 17:13:07 +02:00
Benjamin Pasero 02fcc994ac
esm - port over unit test changes (#225711) 2024-08-15 19:58:52 +02:00
Benjamin Pasero fdc8d882e2
esm - backport worker related changes (#225672) 2024-08-15 13:46:45 +02:00
Connor Peet 7dde0a7943
eng: fix --run path in electron tests not working (#225422)
I assume this broke with some of the ESM work, but I have no idea how it was working before. This should be a better fix.
2024-08-12 18:58:54 +02:00
Robo 00427fda20
chore: update electron@30.3.1 (#225106)
* chore: update electron@30.3.1

* temp: update distro

* chore: update node.js builds

* temp: update distro

* temp: revert node-pty

* Revert "temp: revert node-pty"

This reverts commit e834f75959ffd0078708db764457e05ec0f3b6b6.

* temp: test with oss electron

* chore: update node.js checksums

* Revert "temp: test with oss electron"

This reverts commit 18506aaa82b2cf44e4b5780eac1b929bbf98ac11.

* temp: disable sandbox for smoke tests

* Revert "temp: disable sandbox for smoke tests"

This reverts commit 8596ef5fcc776cc9a14b4546f9e448ccba2acbad.

* test: skip icon validation task smoke tests

* chore: bump distro
2024-08-09 23:44:42 +00:00
Peng Lyu 3b0671e73a
Enable notebook smoke test for electron only (#224968) 2024-08-06 10:38:22 -07:00
Benjamin Pasero 4c1b0e9ff1
esm - reduce diff (#224919)
* esm - reduce diff

* .

* .

* .

* .

* .
2024-08-06 17:32:43 +03:00
Alex Ross c23e35103f
BUILD: skip "check object leaks" test (#224923) 2024-08-06 01:55:35 -07:00
Peng Lyu df447e7ad4
Merge pull request #224547 from microsoft/rebornix/net-boa
Enable notebook smoke test and capture memory leaks
2024-08-05 15:44:22 -07:00
Peng Lyu e4702fa7ce Simplify getInstances. 2024-08-05 14:14:23 -07:00
Peng Lyu 30330d22a2 release object group 2024-08-05 13:24:53 -07:00
Peng Lyu af98c564c2 accurate heap leak checks 2024-08-02 14:32:46 -07:00
Peng Lyu d6349df968 fix false negative test 2024-08-02 13:43:33 -07:00
Peng Lyu 317a4589c2 Support tracking multiple leaks 2024-08-02 12:28:02 -07:00
Peng Lyu 8355790709 Enable notebook smoke test and capture memory leaks 2024-08-01 23:41:08 -07:00
Alex Ross eb1f210220
Skip "should persist buffer content"
Part of #216464
2024-08-02 07:51:53 +02:00
Megan Rogge 3cf2a00cef
rm carriage returns from terminal buffer string in smoke test (#224525) 2024-08-01 14:40:21 -07:00
Megan Rogge 14253f3cd9
fix flaky terminal persistence smoke test (#224414)
fix #216464
2024-07-31 11:25:36 -07:00
Daniel Imms 249b7c2c78
Skip all terminal smoke tests on Linux
These can flake due to the pty host crashing. Disabling for now, they require
more investigation. Tracked in #216564
2024-07-31 08:04:09 -07:00
Alex Ross 5410988877
Skip terminal editor tests (#224375)
Part of #224269
2024-07-31 01:29:03 -07:00
Matt Bierner 84607a2fe2
Fix some always true/false errors in codebase (#223359)
* Fix some always true/false errors in codebase

Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase

Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases

* Bump TS version

* Fix unreachable in build scripts

* Bump versions

* restore intent

* Revert package.json change

* Fixing a few new layer checker errors

These are global in node now

* Skip lib check in integration project

* One more skiplibcheck

* More skip lib

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2024-07-30 15:37:27 -07:00
Alex Ross 447e8dcee6
Disable failing terminal tests (#224273) 2024-07-30 02:24:36 -07:00
Alex Ross eb4633fe7f
Re-merge introduction of tree sitter (#223474)
* Make space for tree sitter

* Add the tree sitter wasm file

* Very naive tree-sitter syntax highlighting for html, with a layer breaker

* Update tree when content changes

* WIP for making abstract tokens class

* Handle theme changes

* Replace entire text model value with parse callback

* Perf improvements

* Add tree-sitter-typescript

* Add typescript + better initial parsing

* Refactor into tree parsing service and fix flaw in parse callback

* Remove things that aren't the parser service

* Add yielding

* Remove changes that aren't required for PR

* Remove more file changes

* Reduce yield to 50 ms

* Fix incremental parsing

* Try update node-abi

* Revert "Try update node-abi"

This reverts commit df28801e31.

* Update text buffer chunk api

* fix build

* Remove tree-sitter dependency

* Adopt new, as yet unpublished, `@vscode/tree-sitter-wasm` package

* Use published `@vscode/tree-sitter-wasm` package

* Break `TreeSitterTree` and `TreeSitterParserService` into better pieces
and:
- document the order of editor changes
- use service injection where `TextModel` is constructed

* Fix tests

* Remove unneeded import

* Fix missing tree-sitter-wasm in web and remote

* Make package.jsons match

* Add @vscode/tree-sitter-wasm to web loader config

* Try using importAMDNodeModule

* PR feedback

* Add race condition test for changing language while loading language

* Use same timeout

* Queue content changes

* Remove override dispose

* Move queue into TreeSitterTree

---------

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2024-07-29 11:31:28 +02:00