Commit Graph

50 Commits (db5e776d713d00c0615d84b78eaa8b9a986cb779)

Author SHA1 Message Date
Matt Bierner e2e048ded8
Merge pull request #230345 from microsoft/dev/eslint-9
Eslint 9 migration
2024-10-07 09:15:12 -07:00
Matt Bierner 0deec1d730
Exclude generated codicon.css file from hygiene (#230501)
Fixes #230388
2024-10-07 16:25:03 +02:00
Matt Bierner 9c86c96a8a Switch back to use eslintignore file for sdl tooling
However use a different filename to avoid a warning
2024-10-03 09:44:50 -07:00
Matt Bierner f22a1167e4 More fixes 2024-10-02 17:22:33 -07:00
Matt Bierner 489c180f25 Merge branch 'main' into dev/eslint-9 2024-10-02 14:50:59 -07:00
Matt Bierner e456f4cb66 Start eslint 9 migration
For #230339

Starts migrating to eslint 9. Everything runs but it produces a number of errors
2024-10-02 14:45:28 -07:00
Benjamin Pasero c5b6ef14e6
esm - more cleanup (#230285) 2024-10-02 11:55:17 +02:00
Robo b5a6aa14a8
feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Alex Ross 977f832a30
Simple tree sitter based syntax highlighting for typescript (#225252)
* Simple tree sitter based syntax highlighting for typescript

Part of #210475

* Implement onceIf using filter

* Mix monaco

* Fix tests

* Switch back to classic

* PR feedback

* Fix bug causing test failure

* Update tree-sitter-wasm

* Fix monaco editor tree shaking

* Fix running monaco checks on Windows

* Use dummy tree sitter service in standalone

* PR feedback
2024-08-19 21:56:31 +02:00
Benjamin Pasero 0dea4804f4
esm - introduce VSCODE_BUILD_ESM variable (#225586) 2024-08-14 14:49:26 +02:00
Daniel Imms 1416d5bd96
Basic code completions 2024-07-18 11:32:28 -07:00
Dirk Bäumer 20775fd417
Reenable yarn eslint (#220037)
* Reenable yarn eslint

* Fix eslint errors

* Fix compile error

* Fix another compile error

* Disable eslint errors
2024-07-05 12:26:44 +02:00
Matt Bierner f86d0f7324
Exclude product.overrides from hygiene (#211396) 2024-04-25 18:18:09 -07:00
Matt Bierner 45e2e0bfd0
JS/TS package acquisition (#184438)
* Experiment with adding ata using `@types` packages shipped in an extension

* Use own file system instead of `https`

* JS/TS type support on web

* Tsconfig needs esModuleInterop not module:nodenext

We actually want webpack to emit commonjs, but need to write ES default
imports to use node-maintainer

* fix package.json indentation

* Adding setting to disable web type acquisition

* Fix merge of yarn lock

* Fixing merge errors

* Fixing errors

* Pick up package externally

* Fixing conflicts

* Bump version

---------

Co-authored-by: Kat Marchán <kzm@zkat.tech>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2023-08-28 00:49:40 -07:00
Robo 8147d6bee1
fix: bump node-gyp dependency to v9.4.0 (#189308) 2023-07-31 06:53:30 -07:00
Alex Ross dc142e4cd1
BUILD: Exclude third party notices from indentation filter (#187913) 2023-07-14 11:52:40 +02:00
Connor Peet 22bb4b95cc
build: exclude the cli third party notices from hygenie (#187843)
This might get moved later on, but for now exclude them
2023-07-13 16:50:43 +02:00
Martin Aeschlimann 780b2f5758
add linter for css variable names (#176769) 2023-03-10 07:33:02 -08:00
Peng Lyu 687cc4fe97
Fix #168070. Filter ipynb output from hygine (#169691) 2022-12-20 23:33:30 +01:00
Connor Peet bf36a10c47
cli: use packaged openssl instead of artisanal builds 2022-10-20 17:14:14 -07:00
Connor Peet 24a51e506f
try using vcpkg for everything 2022-10-18 10:58:50 -07:00
Connor Peet 3762635fe1
move cli to top level 2022-09-20 08:42:44 -07:00
Connor Peet 3ca6d73169
exclude rust cli from linting/hygenie 2022-09-19 13:29:24 -07:00
Matt Bierner 3c37a5a8d7
Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Benjamin Pasero cfc0119755
Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
2022-09-15 08:26:22 +02:00
Daniel Rosenwasser 0cbcb1b1ab
JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
isidor a5db59ad6b
use .mp3 files for audio cues 2022-08-22 10:58:58 +02:00
Z. Grace Moreau a79956ac84 try exempting `*.fish` files from copyright requirements
This appears consistent with the treatment of other shell scripts.
2022-08-08 14:49:38 -06:00
Matt Bierner bbe7b54cf4
Remove custom editor tests (#152777)
These tests are not actively being run or maintained. Removing them for now
2022-06-21 15:37:19 -04:00
Alexandru Dima 9db5a3674e
Bring the nls loader plugin into our sources (#152338) 2022-06-16 22:01:19 +02:00
Alexandru Dima d132489cd0
Bring the css loader plugin into our sources (#152205) 2022-06-15 16:53:02 +02:00
Joao Moreno 8627bd2569
add policy admx/adml files 2022-04-20 16:19:38 +02:00
Matt Bierner acd19fbc30
Add notebook-renderer to hygiene filter 2022-03-08 17:44:15 -08:00
Daniel Imms 2687b53d77
Get zsh shell integration working again (#143963)
ZDOTDIR/.zshrc is now created manually on the pty host

Fixes #143629
2022-02-25 11:19:19 -06:00
rebornix f2b7964599
re #142429. Image renderer moved to extension. 2022-02-07 12:49:20 -08:00
João Moreno 7455bc43ad
unify eslint filters (#142063) 2022-02-03 08:12:23 -08:00
Benjamin Pasero 13461f8c61
Web: change `yarn web` to run with our server instead of playground (#139725)
* web - first cut `yarn web` via our server

* properly pipe output

* web - remove traces of web playground

* web - remember last opened workspace for convinience

* use vscode-test-web for server less, clean up web commands

* fix comment

* fix `yarn web`

* rename to code-server

* open system browser

* code-server script: use minimist

* test resolver: use ./scripts/code-server

* integartion tests: fix code-server command name

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-01-20 13:48:08 +01:00
Henning Dieterichs 13655086ca
audio cues: webm -> opus 2022-01-11 15:58:38 +01:00
Henning Dieterichs 675014ed53
Play a sound when the cursor enters a line with a breakpoint. 2022-01-05 16:16:10 +01:00
Alex Dima a704a69394
Enforce that source code uses a small subset of Unicode 2021-11-03 23:34:41 +01:00
Matt Bierner 474d4951d8
Switch to dompurify for sanitizing markdown content (#131950)
* Switch to dompurify for sanitizing markdown content

Switches us from using `insane` to instead use `dompurify`, which seems to be better maintained and also has some nice features, such as built-in trusted types support

I've tried to port over our existing sanitizer settings as best as possible, but there's not always a 1:1 mapping between how insane works and how dompurify does. I'd like to get this change in early in the iteration to catch potential regressions

* Remove logging and renaming param

* Move dompurify to browser layer

* Fixing tests and how we check valid attributes

* Allow innerhtml in specific files

* Use isEqualNode instead of checking innerHTML directly

innerHTML can return different results on different browsers. Use `isEqualNode` instead

* Reapply fix for trusted types

* Enable ALLOW_UNKNOWN_PROTOCOLS

I beleive this is required since we allow links to commands and loading images over remote

* in -> of

* Fix check of protocol

* Enable two more safe tags
2021-09-03 12:17:02 -07:00
Robo 4fee848f2f
fix: CXXABI requirements for older distros (#129360)
* fix: use clang and libcxx from chromium

* chore: add flags for Link-Time Optimization

libcxx builds from upstream are built with LTO, avoiding these
flags will cause miscompiles

* chore: add lto flags to compilation units
2021-08-06 08:48:45 -07:00
Matt Bierner 34f0fcaf52
Rename `notebook-markdown-extension` to `markdown-math`
This makes it more clear what this extension is contributing
2021-06-08 09:58:54 -07:00
Matt Bierner e01b60782a Exclude compiled notebook files from hygine 2021-03-17 13:33:47 -07:00
Matt Bierner 1f2313b4a2 Add back custom editor test workspace 2021-03-10 11:38:06 -08:00
Matt Bierner 6a9f8ac758 Rename markdown math extension to notebook-markdown-extensions
We will use this to experiment with different types of extensions, not just math
2021-02-22 16:07:48 -08:00
Matt Bierner 35f855796b
Add support for markdown notebook renderers (#115191)
* Use shared webpack version instead of installing locally for simple-browser

* Use npm for building markdown preview

* render markdown in webview.

* update markdown preview height and offset

* Add basic custom notebook renderer point

* update css

* style update.

* update markdown header padding left

* Add example of loading katex to extend the markdown-it renderer

* Rename global to make clear it only applies to markdown-in

* hide/remove markdown preview

* Add wait for initial markdown preview rendering before showing notebook

* Add double click to switch to editing mode

* Fix markdown cells not getting updated after editing

* style polish

* notebook.experimental.useMarkdownRenderer

* switch render strategy.

* Adding very intial drag drop support for notebook markdown cells

* Implement drag/drop stubs for test classes

* Revert unrelated file changes

* Move markdown notebook math to own extension

* Add missing imports

Co-authored-by: rebornix <penn.lv@gmail.com>
2021-02-10 16:41:53 -08:00
João Moreno 38db1778aa adopt built-in extensions 2021-02-01 14:29:07 +01:00
João Moreno 3c49afeaaf
fix hygiene 2021-01-19 12:11:11 +01:00
João Moreno c6ceb1ab2e isolate eslint from hygiene 2021-01-07 09:15:05 +01:00