de1ae9e2cc
update todo-tag for https://github.com/microsoft/vscode/issues/141993
2022-02-02 12:39:06 +01:00
7ccb868835
make sure to use `.eslintignore` when running `yarn eslint`, this will ensure that cli failure and editor squiggles are always equal
2022-02-02 12:37:29 +01:00
138068aff3
fix https://github.com/microsoft/vscode/issues/141981
2022-02-02 11:44:16 +01:00
bd22470fad
dispose cancellation token listeners
2022-02-02 10:56:03 +01:00
568230ef8b
fix jsdoc
2022-02-02 10:41:06 +01:00
482daf0366
smoke - more logging
2022-02-02 07:00:42 +01:00
892b69f9ae
smoke - log workbench config only in CI
2022-02-02 06:52:08 +01:00
e89b0af0ef
Clean up no-op regex string replace
2022-02-01 19:36:54 -08:00
2ca31fc845
Set aria-label on breakpoint widget editor
...
Fix #141721
2022-02-01 19:08:49 -08:00
6820250dd8
Avoid import from workbench/contrib/debug to api
...
See #141921
2022-02-01 18:41:07 -08:00
14290dc9d4
Remove import from workbench/contrib/debug/ to workbench/api
...
See #141921
2022-02-01 18:36:07 -08:00
bb79477f2e
Enable ipynb serializer tests in web integration tests
...
and reenable NotebookSerializer test in non-web
2022-02-01 18:22:57 -08:00
f498b374c0
large refactor including new secret storage wrapper and overall code clean up and organization
2022-02-01 18:14:31 -08:00
b1781cc7ae
Change click-here link in contributing doc
...
Ref #140059
2022-02-01 17:26:59 -08:00
0aea3d14ab
Fix `_activeLinks` not being disposed of
...
Looks like we were calling forEach but not actually invoking `dispose` on the items. Switch to use `dispose(...)` to avoid this
2022-02-01 17:22:07 -08:00
442227c0db
Remove extra DomEvent type
...
We should just use the actual dom `Event` base type here
2022-02-01 17:22:07 -08:00
d4d029dc28
Fix keyup for folder action item
...
Fixes #141977
2022-02-01 17:17:19 -08:00
161710f9ab
Use variadic version of IConstructor signature
...
Instead of having unique versions of `IConstructor` for various argument counts, instead take the expected argument types as a tuple. This cleans up the code a little and lets us pass in as many arg types as we wish
2022-02-01 17:05:19 -08:00
aad7b3761a
Try simplifying `GetLeadingNonServiceArgs`
...
This new form should support arbitrary argument lengths instead of being limited
2022-02-01 16:28:46 -08:00
5e5d0f6f54
set terminal alignment to top when panel is vertical ( #141972 )
2022-02-01 18:02:57 -06:00
99816b1873
Ensure parameter hints z-index is lower than suggest
...
Terminal screen element's z-index is 31
Fixes #141947
2022-02-01 15:12:06 -08:00
ed8dece1f9
Adjust fallback value in Settings ToC
...
Fixes #141895
2022-02-01 14:39:27 -08:00
3268bbfb8a
Move webview shared code to workbench/common instead of workbench-api
...
For #141921
2022-02-01 14:26:54 -08:00
1f5f78ae83
Remove vscode type import
2022-02-01 14:26:53 -08:00
6578db0170
Move `coreCommands` out of `/controller/` ( #141174 )
2022-02-01 23:03:57 +01:00
f879b1d16f
Move `view.ts` out ( #141174 )
2022-02-01 23:03:57 +01:00
645e144e6e
Move more types to `viewModel.ts`
2022-02-01 23:03:57 +01:00
0ea2ff2261
Reduce `IViewModel` methods
2022-02-01 23:03:56 +01:00
342ab4e38e
Reduce `IViewModel` surface
2022-02-01 23:03:56 +01:00
109666d910
Use disposable store and avoid double registering disposable
2022-02-01 13:59:14 -08:00
79fa352e3f
Clear _editorResolverDisposables when contributions change
...
Looks like items were being disposed of but never removed from the array
2022-02-01 13:59:13 -08:00
66631d1bf6
Use `dispose(...)` instead of `forEach(x => x.dispose())`
...
The `dispose` helper ensures all the items are disposed of even if one of them throws during `.dispose`
2022-02-01 13:59:13 -08:00
90b50dc7e2
Use ?. in a few more places
2022-02-01 13:59:12 -08:00
c3a004ea9b
Use ?. for calls
2022-02-01 13:59:12 -08:00
75786b9fb7
Mark a few more properties as readonly
...
These are taken as object parameters. Making these `readonly` makes it clearer that these are only used as inputs to the function and not modifier
2022-02-01 13:59:11 -08:00
81ac632321
Make markdownStringEqual aware of supportHtml
2022-02-01 13:59:11 -08:00
07acca0129
Merge pull request #141953 from microsoft/aeschli/141831
...
File icon size does not behave correctly with multiple fonts.
2022-02-01 22:34:03 +01:00
ab2fccd147
Add simple origin check
2022-02-01 12:49:49 -08:00
265cca240a
tweak bold regexp ( #141968 )
2022-02-01 14:10:02 -06:00
a48c94c91f
bump node-fetch version in smoke tests
2022-02-01 11:40:45 -08:00
c41a5d9613
Polish fixSettingsLinks match code
2022-02-01 11:02:02 -08:00
7d1f0fda8b
tweak vscode.open command and its test, https://github.com/microsoft/vscode/pull/141944
2022-02-01 18:35:12 +01:00
09c2e177ea
Fix typos ( #141959 )
...
* src: fix typo formated -> formatted
* src: fix typo recieve -> receive
* src: fix typo successfuly -> successfully
* src: fix typo neccessary -> necessary
* extensions: fix typo existance -> existence
* src: fix typo appearence -> appearance
* src: fix typo choosen -> chosen
* src: fix typo unkown -> unknown
* src: fix typo whenever -> whenever
* src: fix typo proccess -> process
* src: fix typo occured -> occurred
* src: fix typo occuring -> occurring
* src: fix typo defintion -> definition
2022-02-01 09:16:37 -08:00
a1a7da7d51
await toggle dev tools
2022-02-01 10:57:04 -06:00
a3b18ff63c
remove unnecessary or
2022-02-01 10:53:56 -06:00
6c33588938
code web script: improve help
2022-02-01 17:38:37 +01:00
884273e35b
code server scripts: use realpath
2022-02-01 17:38:37 +01:00
d971263085
remove the last typescript-vscode-sh-plugin references
2022-02-01 17:38:36 +01:00
fc8a61280b
fix: remove python usage in macos cli wrapper ( #138582 )
...
Fixes https://github.com/microsoft/vscode/issues/134635
Fixes https://github.com/microsoft/vscode/issues/137954
2022-02-01 07:58:28 -08:00
54eb53ba92
define commands converter interface and untangle extHostCommands and extHostTypeConverter, https://github.com/microsoft/vscode/issues/141922
2022-02-01 16:26:08 +01:00
Johannes Rieken
Benjamin Pasero
Rob Lourens
Tyler Leonhardt
Raymond Zhao
Matt Bierner
Megan Rogge
Daniel Imms
Alex Dima
Martin Aeschlimann
SteVen Batten
Caio Agiani
meganrogge
Robo